search

BeamMW / beam-ui

Beam Desktop Wallet (Win / Mac / Linux)
https://beam.mw/
Apache License 2.0
27 stars 23 forks source link

FR 8: Add ability to enable specific Confidential Assets in Beam wallet #1113

Open beam-mw opened 1 year ago

beam-mw commented 1 year ago

Following feature request: https://forum.beam.mw/t/scrap-current-verification-model-allow-manual-adding-of-assets-via-link-ownership-verification-like-keybase/379

beam-mw commented 1 year ago

Specifications:

In Beam Desktop Wallet settings add section ‘Confidential Assets’

Provide complete list of all existing assets including: 2.1 Asset name 2.2 Asset symbol 2.3 Total emission 2.4 Whether asset was created by wallet or contract (if possible)

For each asset provide a toggle to turn it on or off

The assets that are in off (disabled) state will not be shown in the Asset Swaps list

By default, all verified assets will be enabled

Add link to Asset Swaps screen to open the settings for quick changing of the asset visibility

beam-mw commented 1 year ago

On DAPPNET https://github.com/BeamMW/beam-ui/actions/runs/3463926910

Maxnflaxl commented 5 months ago

There are multiple parts to this FR:

  1. asset visibility in the Asset Swaps
  2. manual adding of CAs (on wallet home screen)
  3. add asset via hyperlink
  4. only show added/enabled assets in the Asset Swaps order book

1. Asset Visibility In The Asset Swaps

In Beam Desktop Wallet settings add section ‘Confidential Assets’ Provide complete list of all existing assets including: 2.1 Asset name 2.2 Asset symbol 2.3 Total emission 2.4 Whether asset was created by wallet or contract (if possible)

For each asset provide a toggle to turn it on or off

The assets that are in off (disabled) state will not be shown in the Asset Swaps list

By default, all verified assets will be enabled

Add link to Asset Swaps screen to open the settings for quick changing of the asset visibility

How it looks:

grafik

2. manual adding of CAs (on wallet homescreen)

Multiple users have asked about a MetaMask like way of adding/removing assets from the wallet home screen. This can be easily done by using the existing ```asset filter``` logic. The filtering of transactions should also apply here.

In the forum FR we find two more requests:


Add CA via hyperlink

Create a system where a hyperlink can enable the asset in wallet (similar to how a hyperlink can open Telegram and navigate to a group) where user is presented with a ‘confirm asset add’.

only show added/enabled assets in the Asset Swaps

Once a user has ‘added’ an asset to the wallet, they are then able to see the swap offers, users should only see swap offers for assets they’ve integrated! **Related issues:** https://github.com/BeamMW/beam-ui/issues/1012