BeamMW / beam-ui

Beam Desktop Wallet (Win / Mac / Linux)
https://beam.mw/
Apache License 2.0
25 stars 23 forks source link

[UI part]: enable c++20 #1119

Closed Tatsujin1978 closed 1 month ago

Tatsujin1978 commented 1 month ago
Tatsujin1978 commented 1 month ago

@Maxnflaxl , done.

Tatsujin1978 commented 1 month ago

@Maxnflaxl , by the way, if these files is subject to change after recompilation then maybe would be better to add them into git ignore or something like this?

Maxnflaxl commented 1 month ago

@Maxnflaxl , by the way, if these files is subject to change after recompilation then maybe would be better to add them into git ignore or something like this?

No, the translation files are necessary and updated by cmake. We haven't found out yet why the <byte value="xd"> is added in some cases. @kogawulf experienced this too.

Tatsujin1978 commented 1 month ago

@Maxnflaxl , as I see it coused by lupdate: https://codereview.qt-project.org/c/qt/qttools/+/353347/25 So, maybe we have an outdated tool.

image

Maxnflaxl commented 1 month ago

@Maxnflaxl , as I see it coused by lupdate: https://codereview.qt-project.org/c/qt/qttools/+/353347/25 So, maybe we have an outdated tool.

image

@anatolse

"On Windows, the line endings might be "\r\n", depending on the source file. In .ts files this leads to an extra tag <byte value="xd"/>. Fix this by converting Windows line endings to Unix line endings when handling string literals." (https://codereview.qt-project.org/c/qt/qttools/+/353347/25)

Seems not like we have an outdated tool, but incorrect line endings.

anatolse commented 1 month ago

@Maxnflaxl , as I see it coused by lupdate: https://codereview.qt-project.org/c/qt/qttools/+/353347/25 So, maybe we have an outdated tool. image

@anatolse

"On Windows, the line endings might be "\r\n", depending on the source file. In .ts files this leads to an extra tag <byte value="xd"/>. Fix this by converting Windows line endings to Unix line endings when handling string literals." (https://codereview.qt-project.org/c/qt/qttools/+/353347/25)

Seems not like we have an outdated tool, but incorrect line endings.

ok, I will check en-US.ts then