Determine which files and classes are considered "helper" files/objects and move them into appropriate subfolders.
This requires feedback from other contributors to decide best layout.
Suggested (or to be considered) files -- along with their .h counterparts of course
ELSeedValidator inherits from QValidator, and then seems to implement a regular expression validation manually in its validate() method. The validate method contains the allowed regular expression to be checked against.
Shouldn't this operate in the same way as every other validate method? That is, the regular expression is defined in the QML file, in this case SeedInput.qml.
So, shouldn't ELSeedValidatorsimply inherit from RegularExpressionValidator so it can call the parent validate() method to check the regular expression, and then do the extra code in its validate() method?
Refactor RegExpValidator references
RegExpValidatoris apparently deprecated and it is recommended to use RegularExpressionValidator
Maxnflaxl
commented
1 month ago
Refactor ui/viewmodel
Determine which files and classes are considered "helper" files/objects and move them into appropriate subfolders. This requires feedback from other contributors to decide best layout.
Suggested (or to be considered) files -- along with their .h counterparts of course
Refactor class ELSeedValidator
QValidator, and then seems to implement a regular expression validation manually in its validate() method. The validate method contains the allowed regular expression to be checked against.ELSeedValidatorsimply inherit fromRegularExpressionValidatorso it can call the parent validate() method to check the regular expression, and then do the extra code in its validate() method?Refactor RegExpValidator references
RegExpValidatoris apparently deprecated and it is recommended to useRegularExpressionValidator