search

Beamdog / nwn-issues

Neverwinter Nights: Enhanced Edition Technical Bug Tracker
http://nwn.beamdog.com
31 stars 1 forks source link

[8193.9+] ActionStartConversation from item between PC and NPC doesn't start conversation #30

Open trjohnst opened 4 years ago

trjohnst commented 4 years ago

To Reproduce

  1. Enter module
  2. Pickup convothing (on the ground)
  3. Use convo thing to start a conversation with the dwarf NPC
  4. Observe first conversation line in chat window but no dialog window opens

Specifics

If needed, describe the bug

I was directed to post here from NWNS-1701. Please let me know if I should report this elsewhere.

When an item assigns an NPC to start a conversation with the PC/item activator, the dialog opens with the opening prompt of the conversation but never opens a dialog window.

Code like the following running of an item activation should provide repeat results:

AssignCommand(
  oTarget,
  ActionStartConversation(oActivator, sConversation)
);

I have noticed that if you use the item to force the activator to start the conversation, it sometimes works (flipping oActivator and oTarget) in the code above).

Here's a sample repo: https://github.com/trjohnst/nwn-start-convo-bug The built module is here and here's the code using the library functions.

Happy to connect here or over discord at tpickles#5464

niv commented 4 years ago

I can see what's happening, and why. This isn't a new behaviour though, is it? This should have been happening since 1.69.

I kind of feel that this isn't a bug. The conversation tree is dependent on the Speaker being the first node, so the assignment order matters.

What do you envision should be happening here? Should we add a conditional workaround that flips the arguments internally, if the PC speaker is on the wrong end of the pair?

Or am I misunderstanding this issue?