[8193.21] On DM Entering Factions Reputation wrongly change

[Christian-Vassallo]

To Reproduce

• Write some code line on PCChat to verify your reputation vs main factions (Hostile, Commoner, Defender, Merchant) if(sText == "/rep") { int f=0; for(f=0; f<4; f++) { int rep = GetStandardFactionReputation(f, oPC); SendMessageToPC(oPC, "Rep vs " + IntToString(f) + " : " + IntToString(rep)); } }
• Enter with a client Player Character (PC) (Player A) and check the reputations with /rep (they should be 0 50 50 50).
• Enter with a DM Character and check the reputation. They will become (0 0 50 100).
• All the player entering after the DM, will have reputations wrongly set. To verify: Logout and Enter with another PC (Player B) and check the reputation (they will be 0 0 50 100).

Specifics

• Ubuntu 20.04
• Game build 8193.21
• Steam
• Custom haks (no one affecting the reputation)
• No scripts were running on the module events (except the pcchat for the command /rep)

If needed, describe the bug

It seems that if a DM enters, the factions reputation are wrongly changed vs the PCs and the faction themselves. Also some PNG will fight between each other, even if they belong to the same faction. Before the DM entering event, everything is fine.

Some tips. Let's define player A, name Mario - gameaccount Bros. Let's define player B, name Luigi - game account Biax. When Mario and Luigi can enter in all the possibile combinations - also changing the game account - everything will be fine. Then a DM client enters. Mario Bros and Luigi Biax still have the correct reputation, even logging out and logging in again. However, if Mario enters with a new account (not anymore Mario Bros but Mario Pizza) then also his reputation are set to the wrong values. It's like the server fails to initialize the reputation of new client entering, and it's like the same PC with a new game account is treated as a new PC entering.

[Daztek]

Does this still happen on the latest preview build? By that, I mean a server running the preview build's nwserver.

I can repro it on the development build but not the preview build, myself.

[Christian-Vassallo]

Tested on preview setup (client and server side). The problem seems fixed.