search

Beamdog / nwn-issues

Neverwinter Nights: Enhanced Edition Technical Bug Tracker
http://nwn.beamdog.com
31 stars 1 forks source link

Communications from a server need to be indicated as such (if that's the case) #574

Open jd28 opened 9 months ago

jd28 commented 9 months ago

image

Attempting to log into A Dawn of Heroes. What even is this? I assume it's from the server itself, but nothing indicates that.

Specifics

If needed, describe the bug

A clear and concise description of what the bug is if the repro steps do not make it obvious. No essays! Assume whoever reads this has not had coffee.

If warranted, add videos/screenshots to showcase the issue.

mtijanic commented 9 months ago

This is something someone wrote into BootPC() as a boot message. IIUC they only want to support >= 8193.35-40 version, and based on

Game build (e.g. 8193.8, or commit hash) Latest

I guess they don't do the detection correctly. Maybe they do something like x >= 8193 && y >= 35 && z >= 40 and you're on 8193.36-11.

Anyway, IIUC the issue you're logging is the fact that you don't know if the message is coming from the game/masterserver or from the PW? Technically, all disconnect messages (all messages after joining really) come from the server itself. Even "stock" ones like "ELC validation failed - Illegal Character" are just predefined strings the server sends, but the admin can change them. It has always been this way.

I don't know what would be a good way to resolve this, other than just knowing this quirk? Maybe add "You have been booted from the server" into the title bar of that message box that is currently empty?

Shad000w commented 9 months ago

I don't know what would be a good way to resolve this, other than just knowing this quirk? Maybe add "You have been booted from the server" into the title bar of that message box that is currently empty?

The popup has no Title. If there would be "A Dawn of Heroes" ie. name of the server from which player got booted, then there would be no issue...

jd28 commented 8 months ago

Shadooow's idea is good. Realistically, approximately zero people used nwnx2-linux and that particular feature (I count myself in that fractional 0), in a new more vibrant community I think there should be safe guards against server messages as bad as this one.