PNG is not supported - Githubissues

BhaalM commented 1 year ago

Since PNG is a supported format for nui images, it would be great to add support for these files in nwsync.

WilliamDraco commented 1 year ago

As commented on discord - PNG is a supported format in the current release version of nwsync, as it is built on neverwinter.nim 1.5.4 which did include this type. As it's not working for you, this appears to be a bug rather than lacking feature.

niv commented 1 year ago

Latest release version writes .png files for me just fine. The restype for it has been in the list for years. What's the actual issue?

BhaalM commented 1 year ago

The error I get is:

E, [2023-06-28T23:39:37] -- nwsync_write: ResRef sm_btn_up.2080 is not resolvable (we don't know the file type); origin: Erf:/nwn/Neverwinter/hak/sm_update.hak

I'm with the latest release (I have not compiled nwsync myself)

WilliamDraco commented 1 year ago

Bhaal provided me a copy of the file he was having issues with and I can confirm it has no issues using latest release windows version of nwsync_write. Bhaal is using the linux version.

BhaalM commented 1 year ago

This is what I get when use the --version argument:

nwn@talos:~/nwsync/bin$ ./nwsync_write --version
LICENCE
=======

Copyright 2018 Bernhard Stoeckner <niv@beamdog.com> and contributors.

Permission is hereby granted, free of charge, to any person obtaining a copy of this
software and associated documentation files (the "Software"), to deal in the Software
without restriction, including without limitation the rights to use, copy, modify,
merge, publish, distribute, sublicense, and/or sell copies of the Software, and to
permit persons to whom the Software is furnished to do so, subject to the following
conditions:

The above copyright notice and this permission notice shall be included in all copies
or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED,
INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR
PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
OR OTHER DEALINGS IN THE SOFTWARE.

=======

Library and utilities made with love to support Neverwinter Nights development.

You can find the full source code at: https://github.com/Beamdog/nwsync.nim

nwsync 0.4.3 (/0e3d83, nim 1.6.0)

BhaalM commented 1 year ago

This is absurd. I downloaded again, for the third time, the latest release. The version of nwsync_write is still "nwsync 0.4.3" but now it works with png files.

I really don't know what happened.

I apologize for wasting your time...

Beamdog / nwsync

PNG is not supported #9