Fix aggregations with text queries

BeanieODM / beanie

Asynchronous Python ODM for MongoDB

http://beanie-odm.dev/

Apache License 2.0

1.99k stars 211 forks source link

Closed MrEarle closed 10 months ago

MrEarle commented 10 months ago

This aims to fix the bug referred to in #606.

First time contributing here, so please let me know if I'm missing something or I'm not up to your standards 😁.

roman-right commented 10 months ago

Hi @MrEarle , Thank you for the PR! Could you please take a look at tests? It looks like python3.7 is not supported

MrEarle commented 10 months ago

Oh, you're right! I'll fix it as soon as I have some time for it 👌🏼

MrEarle commented 10 months ago

Fixed the tests. I was using list for typing instead of List.

roman-right commented 10 months ago

Awesome! I'll play with it tomorrow and merge. Thank you!

roman-right commented 10 months ago

Good job! And I like how you avoided Python comparison operations, as they are overridden.