search

BeanieODM / beanie

Asynchronous Python ODM for MongoDB
http://beanie-odm.dev/
Apache License 2.0
1.94k stars 203 forks source link

Update documents.py #810

Closed CAPITAINMARVEL closed 4 months ago

CAPITAINMARVEL commented 7 months ago

fix uniondoc DocType

CAPITAINMARVEL commented 7 months ago

Ah shit

CAPITAINMARVEL commented 6 months ago

@roman-right i think im gonna do it with only type hint improving for the union doc issue its within the union_doc folder i was thinking inheriting from document one but there some function not available in union doc so its more complexe than i thought

CAPITAINMARVEL commented 6 months ago

Bad timing i had to go and shouldnt have push now i think its ok

CAPITAINMARVEL commented 6 months ago

Should be good now i can start again if you want cause with all commits its messy @roman-right

roman-right commented 6 months ago

Hey @CAPITAINMARVEL , Could you please take a look at the tests?

Regarding the amount of commits - everything is ok. I use squash merging strategy - it will be 1 commit in the main branch in the end anyway :)

CAPITAINMARVEL commented 6 months ago

Hey @CAPITAINMARVEL , Could you please take a look at the tests?

Regarding the amount of commits - everything is ok. I use squash merging strategy - it will be 1 commit in the main branch in the end anyway :)

hopefully this time its good

CAPITAINMARVEL commented 6 months ago

fixed ? @roman-right

CAPITAINMARVEL commented 6 months ago

Should be good error now @roman-right

CAPITAINMARVEL commented 6 months ago

yeah i cant remove that error its like an hacky way but Union Doc find work same as document find so thats why i change doc type with Union [uniondoc and document]

roman-right commented 6 months ago

Hi @CAPITAINMARVEL , I'll fix the merge conflict and take a look at the error by the end of today

roman-right commented 6 months ago

Hm, it looks like part of the problem has alternative solution there already. Could you please take a look? @CAPITAINMARVEL