search

BeanieODM / beanie

Asynchronous Python ODM for MongoDB
http://beanie-odm.dev/
Apache License 2.0
1.9k stars 201 forks source link

added time encoder #912

Open 07pepa opened 2 months ago

07pepa commented 2 months ago

I have added time encoded however i suspect there may be issue in pydantic ( speed date) itself see https://github.com/pydantic/speedate/issues/62

roman-right commented 2 months ago

Hi @07pepa , THank you for the PR. It looks interesting. I'll check it out this weekend

roman-right commented 2 months ago

Hi @07pepa , Could you please check the red tests?

07pepa commented 2 months ago

now is green https://github.com/07pepa/beanie/actions/runs/8930039487/job/24529213097

07pepa commented 1 month ago

lets wait how pydantic will resolve this here https://github.com/pydantic/pydantic/issues/9571

roman-right commented 2 weeks ago

lets wait how pydantic will resolve this here Yes, let's wait. THank you!

07pepa commented 3 days ago

@Riverfount there is preaty nasty bug in https://github.com/pydantic/pydantic/issues/9571 we should wait how they resolve it IMHO it would be bad if implementation would differ from theirs and it currently does and bypasses pydantic

07pepa commented 3 days ago

@Riverfount can you remove you approve ? i know this is not usual request... but... in this case is better to wait