BeansGalaxy / Beans-Backpacks-2

1.20 inventory management mod. Designed to solve inventory clutter and transferring items while belonging in vanilla Minecraft's aesthetic.
MIT License
21 stars 1 forks source link

Vanilla recipe book/advancement issues #64

Closed Murdyll closed 5 months ago

Murdyll commented 5 months ago

There doesn't appear to be a way to naturally proc the acquisition of the Leather Backpack recipe for Minecraft's native recipe book feature. However, crafting a Leather Backpack does grant the Iron Backpack recipe.

Once acquired (through commands), all the backpack recipes act as if they are able to be crafted without a crafting table, but these "reduced cost" recipes don't actually function.

In addition, some of the advancements seem to be failing to trigger, such as "fill a leather backpack", or "move items with a hopper" (in fact, the hopper functionality doesn't seem to be working at all, or I'm just misunderstanding it).

BeansGalaxy commented 5 months ago

I cant figure out how to get the recipe book recipe's working, Fixed some bugs where it would hide all other recipes but cant seem to get any other recipe than the iron backpack. Still digging though.

Also I'll double check that all the advancements are working, thanks for letting me know.

BeansGalaxy commented 5 months ago

Also, you mean hoppers aren't working at all?

BeansGalaxy commented 5 months ago

"Fill a Leather Backpack" was checking wrong and "Dye a Leather Backpack" has been renamed to "Equip a Dyed Backpack". I cleaned up some hopper code in the latest commit but I couldn't recreate the hoppers not working. Closing this issue and adding recipe book recipe's to my to-do since they're stable and I'll have to come back to them.

Murdyll commented 5 months ago

Also, you mean hoppers aren't working at all?

That's what I'm not sure about. This could be a "skill issue", but I can't seem to get hoppers to interact with backpacks in any way. What exactly is it that they are supposed to do?

By the way, thanks so much for this mod; it's exactly what I was after. Basing them on Bundles rather than Shulker Boxes is so much more interesting :)

BeansGalaxy commented 4 months ago

Thank you!! I think backpack mods are kinda stupid since they just feel like a cheap version of shulkers. Kinda like using a data pack to add a recipe for diamonds to a dirt block. I'm glad you're liking my spin on the idea.

Hoppers just pull items out like if a minecart chest was on top of them. It could be a visual desync, check if the hopper has items in it because I'm aware of a bug that causes ghost items if many stacks are pulled out.

And I don't know if you're using the latest version (wait until 20.1-0.16-v2, critical bugs in 0.15) but Recipe's are working in the Recipe Book now. I didn't realize you have to gift the recipe's to players using advancements. I'm glad I checked my closed issues, hopefully this cleared things up.