search

BeansGalaxy / Beans-Backpacks-2

1.20 inventory management mod. Designed to solve inventory clutter and transferring items while belonging in vanilla Minecraft's aesthetic.
MIT License
21 stars 1 forks source link

[Bug] Minor issue with inventory texture bug #76

Closed VitaminJake closed 4 months ago

VitaminJake commented 4 months ago

Issue occurs with multiple versions, including latest (0.16)

When using /give commands to give a backpack to a player there is a bug causing the inventory item picture not to display. The backpacks can still be pulled from creative mode inventory just fine, so this is what we use. However, if you /give a player one and they try to equip it, it hard crashes the game. This will lock the server out permanently until an uninstall/reinstall of the mod.

The game crashed whilst rendering entity in world Error: java.lang.NullPointerException: Cannot invoke "com.beansgalaxy.backpacks.core.Kind.isTrimmable()" because "kind" is null

https://github.com/BeansGalaxy/Beans-Backpacks-2/assets/162518177/f0b1b062-bbf3-4a4d-a071-692a62944ddd

BeansGalaxy commented 4 months ago

It's because every backpack holds a key that references a list with it's recipe, size, textures... Since you summoned it in, it gave you a backpack with no key and also no texture. I don't know how to remove the item from /give but I'll look into adding a special command.

Creative mod is a mess rn, but I think everything is finished in terms of survival. I'm just starting to go over everything else so it's super polished for the full release.

BeansGalaxy commented 4 months ago

You can re-open this issue if that happens in survival w/o commands but currently there is no support for creative mode, hopefully changing soon.

VitaminJake commented 4 months ago

Ah understandable, we only encountered it because we were testing to see if we'd fixed other bugs/mod conflicts. Makes sense why it happens. Thanks for the fast response, holy wow

BeansGalaxy commented 4 months ago

Ahaha I want this mod out of beta already so I'm just staring at the Issues page waiting for anything to pop up.