Beanzilla / rangedweapons-1

a mod that adds ranged weapons to minetest.
Other
1 stars 1 forks source link

More refactoring #15

Closed ranguli closed 2 years ago

ranguli commented 2 years ago

@Beanzilla I managed to introduce two regressions in #5 where the amount of ammo in a weapon doesn't decrease after firing, and reloading no longer works properly (only 1/4 sound effects play, and none of the animations). If you happen to see anything that stands out as being responsible for that please let me know. I'm currently looking back at the diffs but having no luck tracing the root of the bug.

Ideally I can fix that regression and have it added to this PR. The last commit without the regression seems to be 17b77262d5618217cc455378c234ce9a52af8746.

ranguli commented 2 years ago

I'm going to close this PR, as I've come to the conclusion it will be faster and easier to rewrite from scratch than to try and debug + refactor the existing codebase. You're welcome to take a look if you want: https://github.com/ranguli/boomstick