Reorganize weapons - Githubissues

Beanzilla / rangedweapons-1

a mod that adds ranged weapons to minetest.

Other

1 stars 1 forks source link

Reorganize weapons #5

Closed ranguli closed 2 years ago

ranguli commented 2 years ago

This PR does a lot of refactoring, as well as:

Create a ranged_weapons table that acts as a global data structure for constants.
Create a gun_data table to use for describing common values, that will eventually be used for every weapon entity in the mod.

Beanzilla commented 2 years ago

When ever you get the re-organizing done let me know then I will accept this PR.

Beanzilla commented 2 years ago

I can hardly wait to start working on improving this code base... now that my issue where I fire a gun and it crashes. (I originally was going to abandon this project... now I might be reviewing this stuff and getting it to a better state)

I feel energy weapons eat the Power Particles at insane rates, compared to physical guns that require the ammo/shells. (Might either buff the generator or just buff the guns so they consume less per shot)

Beanzilla commented 2 years ago

I'm going to work on rewriting all the settings so it's in a global and so it uses minetest.conf (where it should be getting set, rather than hardcoded in some lua file, My own mods are guilty of this too, but now I understand minetest.settings a bit better)

Beanzilla commented 2 years ago

Have you figured out what other_weapons_crafting goes too? (I'd like to make it a better name than other_weapons, but need to know what weapons does it affect?)

ranguli commented 2 years ago

It gets used here in crafting.lua, and that seems to be it.

Beanzilla commented 2 years ago

Looks like a few throwing weapons, then gun parts...

I'm leaning on renaming that to craft_gun_parts (or gun_parts_crafting), Just need to make sure those throwing weapons get moved into throwing weapon category.

I've got some of the settings moved into the settings-conf branch. (This will eventually need to get PRed into master, but after this commit, I see lot's changing and that means I need to wait for you to make this an official PR so I can merge it into master than merge the settings-conf branch)

ranguli commented 2 years ago

I'll wrap up these changes in the next commit or two and mark as ready for review. Once both PRs are merged I'll keep going with new fixes in a new PR.

Beanzilla commented 2 years ago

Sounds good with me. :)

Thank you for your work so far, and looking forward to working more on this project. :1st_place_medal:

ranguli commented 2 years ago

I'm looking forward as well! As it stands this PR does still leave a ton of things broken, but its a step in the right direction.

Beanzilla commented 2 years ago

Merging...

Beanzilla commented 2 years ago

Ok ready for more PRs.