BearStudio / start-ui-web

πŸš€ Start UI [web] is an opinionated UI starter with 🟦 TypeScript, βš›οΈ React, ⚫️ NextJS, ⚑️ Chakra UI, 🟦 tRPC, πŸ” Lucia Auth, β–² Prisma, πŸ–οΈ TanStack Query, πŸ“• Storybook, 🎭 Playwright,πŸ“‹ React Hook Form,β—½From the 🐻 BearStudio Team
https://demo.start-ui.com
MIT License
1.39k stars 129 forks source link

feat: Add Portuguese language #387

Closed qlereboursBS closed 3 months ago

qlereboursBS commented 1 year ago

Describe your changes

I added the Portuguese language. However it has been translated with ChatGPT and it needs to be validated because I don't speak a word of Portuguese πŸ˜„ For instance, the "Admin" nav stays "Admin" but I'm not sure if it should be the case

Also, I saw something that may be a mistake: The text content of the DemoLoginHint component (This is a read-only demo, but you can log in with admin/admin ......) is hard coded, even though it's also translated in the translation files. Is it like this on purpose?

Screenshots

image image image image

Documentation

Nothing to add in the documentation.

Checklist

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
start-ui βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jun 22, 2023 11:45am
ivan-dalmet commented 1 year ago

For the hard coded text of DemoLoginHint, it's normal that it's hard coded but there should not be the keys in the translations, you're right. If you can remove the unused keys for that πŸ™

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

qlereboursBS commented 1 year ago

Ok @ivan-dalmet I just removed the translation file because any translation was used

taorepoara commented 1 year ago

On which version should I base the review, the French one or the English one ?

yoannfleurydev commented 9 months ago

Hey @qlereboursBS , since we released the "v2" of πŸš€ Start UI [web], we'll need you to update this PR if possible. Thanks.

qlereboursBS commented 9 months ago

Hey @qlereboursBS , since we released the "v2" of πŸš€ Start UI [web], we'll need you to update this PR if possible. Thanks.

Ok, I plan to do it next week