Closed qlereboursBS closed 3 months ago
The latest updates on your projects. Learn more about Vercel for Git βοΈ
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
start-ui | β Ready (Inspect) | Visit Preview | π¬ Add feedback | Jun 22, 2023 11:45am |
For the hard coded text of DemoLoginHint, it's normal that it's hard coded but there should not be the keys in the translations, you're right. If you can remove the unused keys for that π
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
Ok @ivan-dalmet I just removed the translation file because any translation was used
On which version should I base the review, the French one or the English one ?
Hey @qlereboursBS , since we released the "v2" of π Start UI [web], we'll need you to update this PR if possible. Thanks.
Hey @qlereboursBS , since we released the "v2" of π Start UI [web], we'll need you to update this PR if possible. Thanks.
Ok, I plan to do it next week
Describe your changes
I added the Portuguese language. However it has been translated with ChatGPT and it needs to be validated because I don't speak a word of Portuguese π For instance, the "Admin" nav stays "Admin" but I'm not sure if it should be the case
Also, I saw something that may be a mistake: The text content of the DemoLoginHint component (This is a read-only demo, but you can log in with admin/admin ......) is hard coded, even though it's also translated in the translation files. Is it like this on purpose?
Screenshots
Documentation
Nothing to add in the documentation.
Checklist
yarn storybook
command and everything is working(If you cannot update the french language, just let us know in the PR description)