Fix : FieldCurrency element overlapping on text - Githubissues

BearStudio / start-ui-web

🚀 Start UI [web] is an opinionated UI starter with 🟦 TypeScript, ⚛️ React, ⚫️ NextJS, ⚡️ Chakra UI, 🟦 tRPC, ▲ Prisma, 🏖️ TanStack Query, 📕 Storybook, 🎭 Playwright,📋 React Hook Form,◽From the 🐻 BearStudio Team

https://demo.start-ui.com

MIT License

1.36k stars 128 forks source link

Fix : FieldCurrency element overlapping on text #476

Closed ntatoud closed 3 months ago

ntatoud commented 3 months ago

Describe your changes

The start (and end) elements are overlapping on the FieldCurrency content. This is because InputCurrency is made with a library other than ChakraUI and the stylings are not working together. To fix that, I added a padding to the InputCurrency inside of FieldCurrency if there is an element.

I tested the field with all 4 sizes of input ('xs', 'sm', 'md', lg') and in order it gives :

closes #474

Checklist

[x] I performed a self review of my code
[x] I tested the feature or fix on my local environment
[x] I ran the pnpm storybook command and everything is working

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
start-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 20, 2024 2:48pm

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud