BeardOverflow / msi-ec

GNU General Public License v2.0
134 stars 41 forks source link

Supported devices list #49

Closed glpnk closed 2 months ago

glpnk commented 1 year ago

Part of project documentation

Plans for next PRs:

teackot commented 10 months ago

How about listing supported features, something like:

Model Class EC name Extras Link Battery thresholds webcam ...
Cool Laptop 15 Business 12345678 + - ...
glpnk commented 10 months ago

@teackot my last thougths was about using Discussions for supported models and other documentation

teackot commented 10 months ago

Like using discussions as docs pages? I think this way docs will be lost among questions and firmware requests

We can also use github's wiki feature for this

teackot commented 10 months ago

Though the issue with the wiki is that only I and BeardOverflow will be able to edit it. But it would work nice for documenting different features the driver exposes in sysfs. That is, "Usage" section of the current readme.md

glpnk commented 10 months ago

This is my second attempt to create "low level" documentation. Also how to implement usable memory map table from #36.

I think mixing code with docs inside same repo is bad, because at least it messing with commit history.

glpnk commented 10 months ago

@teackot What do you think about creating repo for wiki repo content? Like you do for issue template

teackot commented 10 months ago

What do you think about creating repo for wiki repo content? Like you do for issue template

I only created issue template repo as a demonstration, it is already merged into this repo. I think creating separate repos for stuff will cause too much fragmentation for a small driver project

teackot commented 10 months ago

@glpnk Oh, I just found out that github wiki can be edited by contributors and is in fact a separate git repo that you can clone and edit locally, it just needs to be enabled in the repo settings

glpnk commented 10 months ago

Yeah, I know that wiki is something like repo.wiki.git but I thought that is creator editable only.

Also what we need to collect in wiki?

May be

teackot commented 10 months ago

Yes

We can make a single contribution guide with a Windows section, a Linux section, and a section about creating a new configuration in the code

glpnk commented 10 months ago

@teackot Okay. Not related to this theme but what you think about #48 and similar cases and single FW record for two+ different models? Or it pointless in case of possible structural redesign?

teackot commented 10 months ago

I will reply in #48

teackot commented 10 months ago

@glpnk BeardOverflow gave contributors access to the wiki, see if you can edit it

rottenpants466 commented 10 months ago

Maybe do something similar to this?

https://github.com/dmitry-s93/MControlCenter/blob/main/docs/tested_devices.md

teackot commented 2 months ago

Maybe do something similar to this?

https://github.com/dmitry-s93/MControlCenter/blob/main/docs/tested_devices.md

I think it's a good idea to do a similar table. We already have a list of laptops in README and we can just put them in a separate file with a simple list of features for each machine.

I also think we should put it in the /docs directory of the repo instead of the wiki. Wiki is nice, but it is harder to modify and keep track of.

teackot commented 2 months ago

See: #116

glpnk commented 2 months ago

Deprecated, feel free to reuse