search

BeardOverflow / msi-ec

GNU General Public License v2.0
134 stars 41 forks source link

Fix negative start threshold #67

Closed teackot closed 10 months ago

teackot commented 10 months ago

Fixes #56

rottenpants466 commented 10 months ago

Maybe the same should be done to the end threshold values. In my case there was a start -138 and a end -128: https://bugs.kde.org/show_bug.cgi?id=473281

Imagine if a user gets a new MSI laptop and installs linux, he wont find the option to change the thresholds in the system settings. He has to first change them in the terminal to the correct values (0 to 100).

That's why the option to change the thresholds were not appearing in KDE power settings since the values were negative and thus not valid :)

Screenshot_20230821_172106

cheers

teackot commented 10 months ago

As we already found out, your problem was because of the wrong charge control address. So if the value is anything other than 10%-100% or 0x80 then it is better for it to not show up in the settings bc the address is probably wrong

rottenpants466 commented 10 months ago

As we already found out, your problem was because of the wrong charge control address. So if the value is anything other than 10%-100% or 0x80 then it is better for it to not show up in the settings bc the address is probably wrong

Oki :+1: