search

BeardOverflow / msi-ec

GNU General Public License v2.0
145 stars 45 forks source link

Add new model: "1594EMS1" MSI Prestige 16 Studio A13VE #78

Closed glpnk closed 1 year ago

glpnk commented 1 year ago

77

Needs testing and review

glpnk commented 1 year ago

@teackot ready to merge. Review here

UPD: what you think about hiding cpu/basic_fan_speed for unsupported models?

teackot commented 1 year ago

UPD: what you think about hiding cpu/basic_fan_speed for unsupported models?

We should hide it. In fact we should hide any unsupported attributes in the cpu and gpu groups. I have created an issue to keep track of it earlier: #75

teackot commented 1 year ago

Everything looks fine