Squiggly underlines are displayed in the middle of the text

BeardedBear / bearded-theme

The VS Code theme with a long beard.

GNU General Public License v3.0

497 stars 43 forks source link

Squiggly underlines are displayed in the middle of the text #171

Closed ale-scussel closed 2 months ago

ale-scussel commented 3 months ago

Hello, with the latest versions of both vs-code (1.88.0) and bearded-theme (v9.1.4), the squiggly lines from eslint are placed just in the middle of the text and not as underline:

This seems to be a theme related issue as in all other themes i tested the underline is just below the text.

palashmon commented 3 months ago

It's happening in other themes also like

Also, it is reported after the recent VS Code version: Code 1.88.0 update:

https://github.com/microsoft/vscode/issues/209614

BeardedBear commented 3 months ago

Hi! I don't have this problem on my side (windows 11), I have the impression that it could be a linux bug, what OS do you use? Did updating VSCode to 1.88.1 solve the problem?

ale-scussel commented 3 months ago

Hi! I'm indeed on linux (EndeavourOS) and unfortunately the update don't seem to have fixed the issue :(

Ps. I just tested the temporary fix from this comment and it seems to work for now, maybe it can be helpful :)

Spitfire1900 commented 3 months ago

I've reproduced on Windows 11 and Kubuntu. Attached are screenshots of Coffee and Dark+ on Windows 11 with v9.1.4.

acramernc commented 3 months ago

Reproduced on Windows 10 with vscode version 1.88.1 Screenshot from theme "Bearded Theme Vivid Black"

Applying temporary fix mentioned by ale-scussel fixed the issue

Note: in addition to removing the items mentioned in the temporary fix, I also had to remove editorInfo.border to fix blue info squiggles May also need to look at editorUnnecessaryCode.border

ale-scussel commented 2 months ago

This issue seems to have been solved with the new vs-code version.

Spitfire1900 commented 2 months ago

Same. Fixed as of code 1.89.0