CubeForgeGame example not working - connection not registered and and clients time out

Cerzi commented 5 years ago

Version Number and Operating System(s):

Windows 10 Unity 2019.2 && 2018.4

commit 1a6b670b3d9173e369bd19afe0471c568fb7e2f5 (upstream/develop, origin/develop)
Merge: ae3e52a c8aa94f
Author: Peter Halasz <skinn3r@gmail.com>
Date:   Fri Sep 6 15:48:48 2019 +0100

    Merge pull request #320 from tommohawkaction/develop

    Fixes for SteamP2P resending reliable data when the client has bad internet

Update: The bug was introduced in this commit: https://github.com/BeardedManStudios/ForgeNetworkingRemastered/pull/266

commit cdc7b339e8bd164ecdfb68f001c055239d4c99ea (HEAD)
Merge: 7ec97bd 6327b4a
Author: Peter Halasz <skinn3r@gmail.com>
Date:   Tue Aug 13 15:10:21 2019 +0100

    Merge pull request #266 from phalasz/issue/104-local-servers-list

    Issue-104 - Display local servers list before joining game

Expected behavior:

Building CubeForgeGame and starting two instances with one hosting and the other connecting should show Players:2

Actual behavior:

The player count stays at 1 after the client connects. The time is synced correctly with the server, however. After a minute or so, "Player 1 timed out" appears in console. If other instances are started they also join and see the correct server time but eventually time out. The player number does increment correctly ("Player 2 timed out" etc)

When rolling back to master, the bug no longer occurs and the example game runs as expected

Steps to reproduce:

Checkout commit referenced above, load in unity, build game and run. However acording to discord chat the problem may be somehow specific to my own setup

[Optional] Discord Username:

Cerzi

phalasz commented 5 years ago

Unity version?

Cerzi commented 5 years ago

Updated

Cerzi commented 5 years ago

Narrowed the problem down to appearing between develop merge pull request https://github.com/BeardedManStudios/ForgeNetworkingRemastered/pull/265 and https://github.com/BeardedManStudios/ForgeNetworkingRemastered/pull/266

Unlike the latest commit, the client info box in pr266 shows "Loading..." at the top left instead of Player Count: 1

BeardedManStudios / ForgeNetworkingRemastered