search

BeardedManStudios / ForgeNetworkingRemastered

See various forks, also please join the Forge Community fork of Forge Alloy! -> https://github.com/ForgeAlloyCommunity/ForgeAlloy
https://twitter.com/FarrisFaulds
Apache License 2.0
1.49k stars 309 forks source link

Richtext BMSLogger fix #327

Closed Cerzi closed 4 years ago

Cerzi commented 4 years ago

Noticed that BMSLogger uses rich text tags to colorize Debug/Warning/Error logs differently, but the OnGUI call wasn't using a richtext style so the tags were being printed unparsed.

Fixed that and also made a small cleanup by use string interpolation instead of string.Format

phalasz commented 4 years ago

String interpolation is not used as it is a C# 6.0 feature and the project has not yet been updated to use never features as far as I know.

Cerzi commented 4 years ago

I might be wrong on this but the project has .NET framework 4.x set in its player settings which should mean C# 6.0 is available.

Can just remove that commit if that suits as the rich text fix is at least useful

phalasz commented 4 years ago

I personally don't mind as I use string interpolation myself in my projects, just highlighting that as far as I know not everything has been properly moved over.

Crazy8ball commented 4 years ago

Moving forward, I think we can merge this and if anybody has issues they can always revert back to a previous version on master.