BeardedManStudios / ForgeNetworkingRemastered

See various forks, also please join the Forge Community fork of Forge Alloy! -> https://github.com/ForgeAlloyCommunity/ForgeAlloy
https://twitter.com/FarrisFaulds
Apache License 2.0
1.49k stars 311 forks source link

STEAMWORKS define symbol causes bugs #401

Closed TheYellowArchitect closed 3 years ago

TheYellowArchitect commented 3 years ago

Version Number and Operating System(s):

Windows 7 x64 Unity 2018.1.1f1 Forge version 3/10/18 - 19.53.38,04 (master)

Expected behavior:

CSteamId and Callback, existing, do not make any compile errors

Actual behavior:

When I put STEAMWORKS define symbol and Unity detects it, alongside the IDE, I get a bunch of errors, as it seems SteamAPI can not be read properly or whatever

Steps to reproduce:

  1. Install Facepunch https://wiki.facepunch.com/steamworks/Setting_Up
  2. Make sure it works (so, all the code above)
  3. Player define symbols: STEAMWORKS; on Unity's player settings
  4. Get bugs.

For more detailed info, I will cross-link the issue from Steamworks.Facepunch
https://github.com/Facepunch/Facepunch.Steamworks/issues/549
I do not know if the bug is in Forge, I doubt it, but it wouldn't surprise me.
Given the majority of users don't use STEAMWORKS; define symbol, all Steam classes are uncompiled.

I just wish to know how to fix it myself, no pull requests or w/e

[Optional] Discord Username:

Thorlar/Balroth

TheYellowArchitect commented 3 years ago

ok, tl;dr: Steamworks.Facepunch is incompatible with Forge, since BaseSteamP2P and other classes, use Steamworks.NET variables