search

BeardedOranges / RankViewer

RankViewer plugin for BakkesMod (https://bakkesplugins.com/plugins/view/91)
GNU General Public License v3.0
17 stars 12 forks source link

Fix New MMR Numbers #5

Closed jlruan closed 3 years ago

jlruan commented 4 years ago

Added new SSL Ranks, Tournament gamemode, fixed some string handling, other bugfixes

stevenschemers commented 3 years ago

@jruaaa Hey, I downloaded your fork and built the dll but when I launch the game it crashes just after the first logo screen. Would you have any advice on what might cause this? Since the author hasn't accepted the pull request yet I was hoping to use your updates. LMK. Thanks in advance!

greengem commented 3 years ago

Were you able to successfully compile the main branch before trying this?

@jruaaa Hey, I downloaded your fork and built the dll but when I launch the game it crashes just after the first logo screen. Would you have any advice on what might cause this? Since the author hasn't accepted the pull request yet I was hoping to use your updates. LMK. Thanks in advance!

stevenschemers commented 3 years ago

@greengem I was not due to some of the bugs in the main branch. Fortunately, I spoke to @jruaaa on discord and he reminded me to not compile in debugging mode. Once I changed that I was able to successfully compile the plugin and use it.

greengem commented 3 years ago

Thanks. I was having the same problem as you so I'll try that.

joao-haraujo commented 3 years ago

@jruaaa I've created a new pull request with fixes for the latest Bakkesmod update, based on this PR.

jlruan commented 3 years ago

He’s not very active right now, might take a while

On Dec 7, 2020, at 07:11, João Araújo notifications@github.com wrote:

@jruaaa I've created a new pull request with fixes for the latest Bakkesmod update, based on this PR.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

joao-haraujo commented 3 years ago

Yeah, I've noticed. That is why I used your PR, in case someone wants to download and compile themselves.