Bearle / django-private-chat

(Deprecated - Please check out https://github.com/Bearle/django_private_chat2) Django one-to-one Websocket-based Asyncio-handled chat, developed by Bearle team
ISC License
424 stars 132 forks source link

Fix example website #3

Closed grantal closed 7 years ago

grantal commented 7 years ago

There were two bugs I found in the example project:

For the second one, I just took the django templating language url tag out of the javascript because it would be hard to find a solutions using that tag. Instead, I used a relative url which, unlike the url tag, could fail if the urls.py gets updated. I think that that risk of failure is worth not having to exchange variables between javascript and django templating language.

Also I fixed a bug in one of the tests I changed in #2 which had a bug to do with zero padding of datetimes.

delneg commented 7 years ago

Thanks again !