Bearle / django-web3-auth

A pluggable Django app that enables login/signup via an Ethereum wallet (a la CryptoKitties)
Other
88 stars 40 forks source link

Feat/django 4 compatibility #12

Open Vimdar opened 2 years ago

delneg commented 2 years ago

Hello, and thanks for making this PR. It's good when people try to fix the problem themselves & share it with the community. Anyway, it's a big PR and we haven't touched the project for a while. It may take some time to do a comprehensive review, but I'm sure that we'll merge it soon. It could help if you could add some tests, and probably github workflow to have it auto-tested (an example can be seen here https://github.com/Bearle/django_private_chat2/blob/master/.github/workflows/test.yml), that would make the task of verifying the code in this PR easier. If that's too much to ask for, that's alright.