search

Bearle / django-web3-auth

A pluggable Django app that enables login/signup via an Ethereum wallet (a la CryptoKitties)
Other
88 stars 40 forks source link

[pysha3 installation bug] Embedding ecrecover_to_pub() | Removing ethereum package #13

Closed st1vms closed 1 year ago

st1vms commented 1 year ago

Removing ethereum package requirement due to deprecation...

pip was currently unable to download django-web3-auth due to pysha3 missing headers, required to install deprecated ethereum library, see This bug report

Since I really didn't found a replacement with the updated py-evm library docs...

I've basically copied from the ethereum.utils module the only function that impose the requirement-> ecrecover_to_pub , along with the utility functions needed.

Added also coincurve requirement, needed for those utilities. And imposed a version greater or equals than 2.0.0 for rlp

delneg commented 1 year ago

Hi! This package is not used for a while, so I have no means of testing it. Still, LGTM and hope it works

st1vms commented 1 year ago

Rather than embedding those functions, there should be a better way... Like a replacement for ecrecover_to_pub to be found in a non-deprecated library, aligning with web3auth/utils.py logic.