BeatLeader / BeatSaber-Web-Replays

Beat Saber web replay viewer
https://replay.beatleader.xyz/?scoreId=8931530
MIT License
57 stars 12 forks source link

[Question/Suggestion] Why use annoying "click" hitsounds? #30

Open aaronjamt opened 11 months ago

aaronjamt commented 11 months ago

First of all, why does it use the (arguably very annoying and distracting) click sound as a hitsound by defsult, rather thsn the real one from the game? Is it to avoid copyright/licensing issues (does Beat Studios and/or Oculus own that sound?) and, if so, is there a guide for how to extract the official sound from the game files? If there aren't any legal issues surrounding this, then consider this entire GitHub Issue a suggestion instead: to either use the offical sound by default, or to add a checkbox or button to select that.

NSGolova commented 11 months ago

There was a game-like hitsound previously, even with spatial audio support, but I replaced it with the current one. You can still check old hitsounds here, I think they are worse https://royale.beatleader.xyz/?hash=d8c789d89fd5afdfea86ea11c70fb469205c01ea&difficulty=Expert&players=76561198362923485,76561198153101808,76561198072602937,76561198253282811

If you want to change hitsounds there is an option in the settings

aaronjamt commented 11 months ago

I know there's an option to change hitsounds but I haven't been able to find the original game's sounds (only mods to modify them). Personally I found the "click" sound to be extremely loud, sharp on the ears, and distracting from the song, but like the official one. How would I go about extracting the official sounds from the game files?

NSGolova commented 11 months ago

You can still find them in the royale branch: https://github.com/BeatLeader/BeatSaber-Web-Replays/tree/nsgolova/battleroyale/assets/sounds If you find hitsounds too loud - there is a volume mixer button under the main volume slider. Volume mixer will allow changing hitsound volume independently