search

BeatLeader / beatleader-mod

BeatLeader mod for PC Beat Saber
MIT License
105 stars 24 forks source link

Override Existing -- what does it mean? #151

Closed WesternIcelander closed 1 month ago

WesternIcelander commented 2 months ago

One of the settings in BeatLeader's settings says Override Existing.

I suspected that it meant to delete old replays when a new replay is saved. I was able to confirm this by reading the mod's source code. However, without observing behaviour or reading the mod's source code, I would not be able to tell you with 100% certainty that that's how the setting will behave.

I believe it should say Keep Latest Only instead of Override Existing. This will make it much more clear what its meaning is.

It's possible that the words override and overwrite have been mixed up. They sound similar, but they don't have the same meaning. If you were to use overwrite it would still be unclear whether it would simply not save a new replay if an existing replay already existed. Using Keep Latest Only makes it 100% clear what the behaviour of the setting is.

Line 63 in: Source/9_Resources/BSML/FlowCoordinator/Components/ReplayLaunchView/SearchFiltersPanel/ReplaySettingsMenu/ReplayerSettingsMenu.bsml

NSGolova commented 1 month ago

Fixed in the latest release👍