search

BeatLeader / beatleader-mod

BeatLeader mod for PC Beat Saber
MIT License
103 stars 25 forks source link

BeatLeader happily accepts JDFixer "No Leaderboard" songs #20

Closed KatDevsGames closed 2 years ago

KatDevsGames commented 2 years ago

Steps to reproduce:

1: Install BeatLeader and JDFixer. 2: Use JDFixer to change song NJS. (This option should disable score submission!) 3: Play song.

Expected behavior: Song score is not recorded by BeatLeader. Song score is not recorded by in-game high score.

Actual behavior: Song score is submitted to BeatLeader (wrong behavior). Score does not appear in in-game high score (right behavior).

Issue: JDFixer lets the player change the JD and NJS but only the JD is supposed to be editable without disabling score submissions. Editing NJS normally disables submissions from being made.

karghoff-e commented 2 years ago

@KatDevsGames

  1. What version of the game are you using?
  2. I don't remember if JDFixer allows to override NJS. Are you talking about NJSFixer?
KatDevsGames commented 2 years ago

BeatSaber v1.21.0

I am talking about JDFixer, see attached screenshots.

com beatgames beatsaber-20220502-121802 com oculus shellenv-20220502-121856 com oculus shellenv-20220502-121916

karghoff-e commented 2 years ago

This is a PC mode repository, you may want to report this issue to a quest repo. [link] I've forwarded this issue to the developer of quest mode. Thanks for report.

KatDevsGames commented 2 years ago

Thanks! I've gone ahead and reported it at the repo you linked to!