BeatTogether / BeatTogether.Quest

A multiplayer private server for the modding community. Supports crossplay between PC and Quest.
MIT License
136 stars 22 forks source link

Potential Solution for weird crashing, general improvements #13

Closed sc2ad closed 3 years ago

sc2ad commented 3 years ago

This PR implements the following:

General Note: I performed a few style changes, so feel free to reject the PR on the basis of those, although I cannot guarantee when I can next look at this. It is always a good idea to ensure you check the locations you are hooking to make sure they are large enough. The original certificate chain hook was actually overwriting a few bytes into an unrelated method and causing damage that was unnoticeable. This should help fix some crash cases.

As always, message me on Discord at Sc2ad#8836 !

Lauriethefish commented 3 years ago

The new makeIdUpperCase and makeIdLowerCase functions return a string array due to multiple method matches for Concat.

Lauriethefish commented 3 years ago

Can confirm is working.

Kevman95 commented 3 years ago

Merged. All looks well.