BeatsKitano / KafkaRefresh

Animated, customizable, and flexible pull-to-refresh framework for faster and easier iOS development.
MIT License
1.21k stars 142 forks source link

Frozen refresh behaviour at start #8

Closed dannydaddy3 closed 6 years ago

dannydaddy3 commented 6 years ago

When pulling refresh its frozen until you reach some offset. When reached, it starts animating. Is this by design? It seems to me that expected behaviour is when pulling, you see how refresh is already animating, even if it's 1 pixel on screen.

I wanted to use this component, to not reinvent the wheel again, but this push me away. What do you think?

BeatsKitano commented 6 years ago

When the refresh control appears on the screen, even if there is only one pixel, you think the animation should start and I do not quite agree with your point of view. The reason is as follows: 1, KafkaRefresh there are several styles in the refresh control appears on the implementation of animations, there are indeed several styles are in the process of refreshing the animations, which is better for users are not refresh and refresh the two different status. 2, it is easy for me to make some changes, but will this change be better? However, when the user is dragging, it is good to add some animation. I should think about how to add some animation

dannydaddy3 commented 6 years ago

I just got that I understood it bad when explained to you. I agree that user have to separate when refresh is in active status or not, so actually what would be cool if when you pull the refresh it started to fill itself until you reach some offset where refresh actually starts. So exactly as behaviour of standard refresh or for example refresh on youtube app. When as you pull back and forth refresh will fill and unfill itself according offset.

So yeah, when dragging would be good to add some animation because it's familiar behaviour for users. What do you think?

BeatsKitano commented 6 years ago

The original intention of this library open source is to solve the bugs I know of open source libraries. But your advice is very good, I will be in the next free time to add more animation. Thanks for your advice.