Brick and Mossy Stone Brick Walls are bugged

Crows-Parliament commented 4 years ago

When the wall is connected to something on the western side, the textures line up (the bricks are consistent) But when there is a block on top AND the wall connects on the western side, the bricks have a visible split between the centre "pillar" brick texture and the side "wall" brick texture EXCEPT for one of the 4 textures, caused by the fact that that specific bricks on the wall texture change for low or tall side walls (screenshots explain the details).

I've isolated all 4 wall textures in my testing world: Brick Wall Models

Brick block to explain how I kept track of textures:

1st brick wall comparison: Brick Wall 1 low Brick Wall 1 tall

And here with no pillars: Brick Wall 1 low (no pillar) Brick Wall 1 tall (no pillar)

2nd brick wall comparison: Brick Wall 2 low Brick Wall 2 tall

And again with no pillars: Brick Wall 2 low (no pillar) Brick Wall 2 tall (no pillar)

3rd brick comparison: Brick Wall 3 low Brick Wall 3 tall

Again without pillars: Brick Wall 3 low (no pillar) Brick Wall 3 tall (no pillar)

And here is the fourth model: Brick Wall 4 low Brick Wall 4 tall

Screenshots done using the debug stick, but it's the same with blocks instead. The textures do not correspond to what the blocks (& slabs and stairs) use for that same block ; i.e. A brick block placed in the same spot as a wall will have a different pattern of bricks (say dark-light-normal) for the top row as a wall (which would have say dark-normal-normal), however, slabs, stairs, and full blocks share the same texture, not sure is that is a bug but still useful to point out ig.

Beatso commented 4 years ago

The textures do not correspond to what the blocks (& slabs and stairs) use for that same block ; i.e. A brick block placed in the same spot as a wall will have a different pattern of bricks (say dark-light-normal) for the top row as a wall (which would have say dark-normal-normal), however, slabs, stairs, and full blocks share the same texture, not sure is that is a bug but still useful to point out ig.

The blockstates and models for the walls are very different to the block/slab/stairs, so I don't think this is part of the issue.

Beatso commented 4 years ago

Ok so basically the bug is because when the block has the blockstate west=tall, it is meant to apply one of four variants of the tall side model, bug in the blockstate file it is only applying one:

"when": {
  "west": "tall"
},
"apply": {
  "model": "minecraft:block/bricks/wall/side_tall/1",
  "y": 270,
  "uvlock": true
}

This means on all but one variant, it is using the wrong texture, causing this issue.

Fix

The blockstate file should choose between all four variants of the side_tall model.

Beatso commented 4 years ago

This is also an issue on mossy_stone_brick_wall.

Beatso / LittleImprovementsVariated

Brick and Mossy Stone Brick Walls are bugged #23

Fix