BeauNouvelle / SwiftyGuitarChords

A guitar chord diagram drawing library built in Swift
MIT License
122 stars 13 forks source link

Ability to specify Chord Name display type in the drawing function #20

Closed BeauNouvelle closed 2 years ago

BeauNouvelle commented 2 years ago

Currently the library uses the RawValue of the Key and Suffix properties on a chord for the name drawn above the chord diagram.

The library now supports other naming variants, so it makes sense to give developers the option to choose from these variants.

This will need to remain backwards compatible. I suggest adding this to the parameters of the current drawing functions, hardcode (and deprecate) the proxy functions to pass in RawValue, and create a new public function that accepts a new enum for these titles.

Another option is to allow developers to add any text they like to the chord names. Discussion?