BeauNouvelle / SwiftyGuitarChords

A guitar chord diagram drawing library built in Swift
MIT License
122 stars 13 forks source link

Fix chords with incorrect MIDI values #23

Closed Desbeers closed 2 years ago

Desbeers commented 2 years ago

Update all the chords in the database with an incorrect MIDI value.

The JSON is on purpose 'pretty printed' because else any other commit to the database will replace the whole file and you can't see the diff. I don't know how much performance impact this will have...

BeauNouvelle commented 2 years ago

We can test that out. For the most part though I think it would be barely noticeable. I'd even encourage other developers to load them in at app launch if needed, and cache them in a way that makes sense to their app.