search

BeauNouvelle / SwiftyGuitarChords

A guitar chord diagram drawing library built in Swift
MIT License
122 stars 13 forks source link

Check chords in the database #25

Closed Desbeers closed 1 year ago

Desbeers commented 1 year ago

Checked, 'major', 'minor', 'sus2', 'sus4', '7sus4', '7', 'dim', 'dim7', 'aug', '6', '6/9' and '7b9' chords so far. Many were incorrect, often because of the bass-note.

BeauNouvelle commented 1 year ago

This is brilliant. Thank you for putting in this work.

Desbeers commented 1 year ago

My pleasure! Learned a lot of music theory! The remaining chords become more and more difficult and first I have to find-out how to properly check them. My 'Chord Lookup' logic in the database program is not so smart yet...

Desbeers commented 1 year ago

This is it for the moment. I'm not an advanced guitar player and also not a real programmer. Both are not my job; just a hobby. I'm a captain on ships; a totally different job.

Rewrote my 'chord parser' many times and enjoyed it! I learned a lot about music theory and also about Swift programming.

I think my PR with 'chords update' is pretty accurate. Not perfect. I'm sure there are still some mistakes, however, it is better than it was before.

Desbeers commented 1 year ago

Checked the 'checked chords' one more time. Added a lot of qualities to my 'Chord Database' app and it will find a lot of chords now. I don't have the time anymore to go trough all of them but there are still a lot of errors in the more obscure chords...

BeauNouvelle commented 1 year ago

That's alright! I'll take a look through an get this merged soon!

BeauNouvelle commented 1 year ago

Thanks for the help!