search

BeautifulTrouble / beautiful-rising

The genetic code for the Beautiful Rising platform.
https://beautifulrising.org/
5 stars 0 forks source link

Arabic leaking into the site? #102

Open DianaHajTPS opened 8 years ago

DianaHajTPS commented 8 years ago

screen shot 2016-10-03 at 12 48 35 pm

I'm just noticing this. I'm not sure if it's a consequence of working on the arabic, just thought I'd flag it here.

Also I'll take this opportunity to make a reminder about the arabic fonts, listed here #70 :)

phillipadsmith commented 8 years ago

Hi @DianaHajTPS: Quick request -- no need to assign me to tickets relating to the website. Thanks! :-)

daveomitchell commented 8 years ago

I'm seeing it too -- as well as a Portuguese duplicate of Salt March. (These seem to be the only two pieces leaking through.)

screen shot 2016-10-03 at 11 55 02 am

I was doing some correcting of Arabic document titles this morning at Adrian's request: adding "DONE" as well as "SNAPSHOT/GALLERY/FULL." Maybe that's the cause?

daveomitchell commented 8 years ago

updates: The Arabic translation of "Lysistrata project" is now no longer showing up, after I removed "DONE" from the document title.

The Portuguese translation of salt march is still showing up, however, even without DONE or READY in the title.

adrian-the-git commented 8 years ago

I'm curious whether this is a language detection issue or related to the way modules are indexed, but whichever it is will be relatively straightforward to fix. I just don't think I'll be able to get to it until next week.

DianaHajTPS commented 8 years ago

Hmmm there's more Arabic now when I'm searching for keywords, are these labeled as "Done" as well Dave?

screen shot 2016-10-05 at 10 06 26 am

daveomitchell commented 8 years ago

Ok, @adrian-the-git -- I will hold off on fixing Arabic document titles, and, @DianaHajTPS, will go back and undo the ones I've added DONE to, until this is resolved.

daveomitchell commented 8 years ago

A further thought: going forward, it might be better to specify which subfolders different language settings pull from rather than rely on language detection, as this is only going to get more complicated as more languages get added.