BeautifulTrouble / beautiful-rising

The genetic code for the Beautiful Rising platform.
https://beautifulrising.org/
5 stars 0 forks source link

Design: Patterns for Theories + Methodologies are the wrong height #93

Closed DianaHajTPS closed 8 years ago

DianaHajTPS commented 8 years ago

it seems like the height on the patterns of Theories and Methodologies is much higher than the rest when filtering by module type. These two module types should match the other 3 patterns in height.

Reference of Theories and Methodologies patterns in comparison to Principles: screen shot 2016-08-24 at 3 16 56 pm screen shot 2016-08-24 at 3 16 59 pm screen shot 2016-08-24 at 3 17 02 pm

adrian-the-git commented 8 years ago

I used the patterns as provided—those two are much larger. If I crop them, should the background patterns (the ones behind the sorting widget) remain the original size?

I just want to point out that this element has 6 distinct layouts which all have to be adjusted for 3 distinct viewport sizes and translations with different text lengths. Keeping all 18 layouts pixel perfect has proven to be a bit of a time sink.

DianaHajTPS commented 8 years ago

You are absolutely right! I went back to the files and checked and remembered the rational. I needed to space theories and methodologies more in order for the overlapping pattern to work.

Here's a simple solution for this instance so it doesn't look like an error anymore: Can you please decrease the height on theories and methodologies on this instance only so that the 3rd row of the pattern doesn't peak through as it's doing now. If that messes up everything else and it's easier for me to provide you with 2 new svg files for theories and methodologies that don't have a 3rd row i'm happy to do so. Just let me know how you'd like to proceed.

adrian-the-git commented 8 years ago

Ah, that's super simple. Cool :)