questions about display grid

Becca-Saunders / svg-icon-sets

Use SVG icons sets to create a small layout with different icons.

0 stars 0 forks source link

questions about display grid #1

Open Becca-Saunders opened 3 years ago

Becca-Saunders commented 3 years ago

Hello! @anna-pokhilenko @wendywarren

We might go over this in class so maybe I'll be able to figure this out on my own but I am having trouble getting the information into different columns. Something to do with the grid areas I'm sure. I'm just not sure what tags to put where.

Also I seems I am still having issues with github. I have attached a zipped file incase it still isn't working. Let me know if there are any other problems I can fix.

Thanks! Becca

saunders-becca-svg-icon-sets.zip

anna-pokhilenko commented 3 years ago

Thank you! Will take a look now.)

anna-pokhilenko commented 3 years ago

So the main issue was that you started developing for bigger screen first, but we need to do it backwards! First, we are developing for smaller screens and put everything in a one column with grid-template areas. Then you have to call media query, and it should be "min-width: 38em". You had "max-width:38em" there. You also need just only one media query!

I am attaching the screenshots of fixes I made: