search

Beckhoff-USA-Community / SPT-Libraries

MIT License
70 stars 16 forks source link

Tracing: AddWithJson / AddEntryWithJson #4

Closed stefanspiegel closed 1 year ago

stefanspiegel commented 1 year ago

Hi all,

I have updated to SPT_Base_Types V3.0.1. The Function Block FB_BaseFB no calls a Method xxx.AddWithJson. This is not compiling. Shouldn't it be xxx.AddEntryWithJson?

Thanks for your answer.

Best regards, Stefan

nshiggins commented 1 year ago

Thanks Stefan I thought I fixed this yesterday--is it still an issue?

MarkLewis-Beckhoff commented 1 year ago

Forgot the () ?

Sent from Ninehttp://www.9folders.com/

From: Nick Higgins @.***> Sent: Friday, December 16, 2022 09:20 To: Beckhoff-USA-Community/SPT-Libraries Cc: Subscribed Subject: Re: [Beckhoff-USA-Community/SPT-Libraries] Tracing: AddWithJson / AddEntryWithJson (Issue #4)

CAUTION: External Email!!

Thanks Stefan I thought I fixed this yesterday--is it still an issue?

— Reply to this email directly, view it on GitHubhttps://github.com/Beckhoff-USA-Community/SPT-Libraries/issues/4#issuecomment-1354926924, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMYD3QNR4XLLQP2UIARNVU3WNR3D3ANCNFSM6AAAAAATA5EX54. You are receiving this because you are subscribed to this thread.Message ID: @.***>

This email contains confidential information. If you have received it in error, you must not read, use, copy or pass on this e-mail or its attachments. If you have received the e-mail in error, please inform me immediately by reply e-mail and then delete this e-mail from your system. Thank you

Diese E-Mail enthaelt vertrauliche Informationen. Sollten Sie sie irrtuemlich erhalten haben, duerfen Sie diese E-Mail oder ihre Anhaenge nicht lesen, verwenden, kopieren oder weitergeben. Sollten Sie die Mail versehentlich erhalten haben, teilen Sie mir dies bitte umgehend per Antwort-E-Mail mit und loeschen Sie diese E-Mail dann aus Ihrem System. Vielen Dank

nshiggins commented 1 year ago

No--the Trace() and TraceWithJson() methods in FB_BaseFB are just wrappers for the global tracing FB that is in SPT_Tracing library.
They call the global AddEntry() and AddEntryWithJson() and pass in the caller's FB instance name, etc. The JSON stuff was a last minute addition and I changed the SPT_Tracing method name (was AddWithJson() --> AddEntryWithJson()) right before committing the libraries and didn't change the wrapper method. Too excited to get it off my plate--my mistake.