search

Beckhoff / ADS

Beckhoff protocol to communicate with TwinCAT devices.
MIT License
493 stars 194 forks source link

reduze required CMake version for Ubuntu bionic #144

Closed simonschmeisser closed 3 years ago

simonschmeisser commented 3 years ago

Ubuntu Bionic/ 18.04 comes with CMake 3.10.2 by default. As I didn't see anything special in the CMakeLists.txt I'm proposing to relax this requirement a bit.

Any reason for picking 3.13 in your initial contribution @miq

pbruenn commented 3 years ago

@simonschmeisser if @miq agrees I am fine to merge the content of your change. However, please spell check your commit message and use CMake: as a prefix for your subject line. Here is a link, which might help to further improve the commit messages text: https://chris.beams.io/posts/git-commit/ Thanks, Patrick

miq commented 3 years ago

Fine with me. As long as we do not need/use features of newer versions it is good to reduce the requirement.