[v4] Replace promiscuous with promise-polyfill for better support

Becklyn / mojave

A library of commonly used JavaScript tools and helpers by Becklyn

BSD 3-Clause "New" or "Revised" License

5 stars 3 forks source link

[v4] Replace promiscuous with promise-polyfill for better support #216

Closed keichinger closed 5 years ago

keichinger commented 5 years ago

Q	A
Bug fix?	yes
New feature?	no
Improvement?	yes
BC breaks?	no
Deprecations?	no
Docs PR	none

Apparently promiscuous doesn't support Promise.finally, which the new polyfill does. We could argue whether we should see this PR as a bug fix or a simply a feature PR. Technically it's a new feature. However, that Promise.finally was even missing might be considered a bug/oversight.

apfelbox commented 5 years ago

Should count as bug fix, as it was a bug that it wasn't supported earlier.