Closed keichinger closed 6 years ago
The AnimationResult
only has two states: interrupted or finished.
So we can just use true
(finished) and false
(interrupted).
So should it remain an object then or should we just resolve the AnimationDirector
Promise with true
and false
?
I would just use a boolean
Fair enough. I've appended the changes to the previous commit to keep the mojave.AnimationResult
type off the history to avoid any potential confusion.
Build errors are unrelated to the changes. It's just SauceLabs being SauceLabs again. The test browsers can't be spawned thus the build has failed.
Thanks!
We’re now always resolving to prevent any promise chain errors bubbling into user land code since it’s an expected code and not an exception.
Instead of cancelling the promise with
undefined
, we’re resolving with an newmojave.AnimationResult
object that represents various states