search

Becksteinlab / GromacsWrapper

GromacsWrapper wraps system calls to GROMACS tools into thin Python classes (GROMACS 4.6.5 - 2024 supported).
https://gromacswrapper.readthedocs.org
GNU General Public License v3.0
169 stars 53 forks source link

codecov shows develop by default #156

Closed orbeckst closed 6 years ago

orbeckst commented 6 years ago

We recently switched GW to using master but codecov still thinks that develop is the default. Therefore, our badge and the codecov GW landing page show the outdated develop branch.

Instead it should represent the codecov master.

Supposedly, Codecov uses the repository default branch but it seems it does not notice when I change the default branch in GitHub.

orbeckst commented 6 years ago

As a workaround I will manually set the master branch in a new .codecov.yml.

orbeckst commented 6 years ago

This did not fix the issue. Codecov is still displaying outdated develop.

Not really sure how to fix it properly.

I can always switch the badge but I don't like this workaround.

orbeckst commented 6 years ago

The branches overview still shows that develop is the default branch (even though I deleted develop in GitHub). codecov_gw_branches

Clicking on the develop (default) marker just leads me to https://docs.codecov.io/docs/codecov-yaml#section-caching-the-repository-yaml where I can find https://docs.codecov.io/docs/codecov-yaml#section-master-copy

The Team YAML https://codecov.io/account/gh/Becksteinlab/yaml is empty, so it should not override anything.

orbeckst commented 6 years ago

Btw, the new .codecov.yml was validated:

$ curl --data-binary @.codecov.yml https://codecov.io/validate
Valid!

{
  "codecov": {
    "branch": "master"
  }
}
richardjgowers commented 6 years ago

Ah sorry. It might just be cached for a while? On Fri, Aug 17, 2018 at 2:06 PM, Oliver Beckstein notifications@github.com wrote:

Btw, the new .codecov.yml https://github.com/Becksteinlab/GromacsWrapper/blob/master/.codecov.yml was validated https://docs.codecov.io/docs/codecov-yaml#section-validate-your-repository-yaml :

$ curl --data-binary @.codecov.yml https://codecov.io/validate Valid!

{ "codecov": { "branch": "master" } }

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/Becksteinlab/GromacsWrapper/issues/156#issuecomment-413960995, or mute the thread https://github.com/notifications/unsubscribe-auth/AI0jB010G8KWGFxbaGZts1VKy2RbMmPdks5uRxROgaJpZM4WB-yv .

orbeckst commented 6 years ago

Not sure. I just sent an email to support@codecov.io – maybe they can help.

orbeckst commented 6 years ago

Follow up: https://codecov.freshdesk.com/helpdesk/tickets/298 (note: you need to be me in order to see it...)

orbeckst commented 6 years ago

Update: codecov now shows master as default and the landing page https://codecov.io/gh/Becksteinlab/GromacsWrapper also shows the data for master.

I marked the develop branch as deleted (there's a little link at the bottom which I only saw now for the first time) and this seems to also have fixed the badge, at least if I do not include graph in the URL: it's now properly reporting the percentage for the full master (62%)

It is possible that my generic default badge URL is wrong. I'll change to the second option.