Becksteinlab / GromacsWrapper

GromacsWrapper wraps system calls to GROMACS tools into thin Python classes (GROMACS 4.6.5 - 2024 supported).
https://gromacswrapper.readthedocs.org
GNU General Public License v3.0
169 stars 53 forks source link

docs incomplete on readthedocs #32

Closed orbeckst closed 8 years ago

orbeckst commented 8 years ago

There are huge gaps in the autogenerated docs on http://gromacswrapper.readthedocs.org. Needs to be read, checked, and fixed.

Example: missing docs for most building block modules: http://gromacswrapper.readthedocs.org/en/latest/gromacs/building_blocks.html

dotsdl commented 8 years ago

We can use conda to build environment on readthedocs now. We use this for MDSynthesis and it works quite well. Happy to set this up.

There are conda gromacs builds from acellera we can use to grab a recent gromacs to build classes against: https://anaconda.org/acellera

orbeckst commented 8 years ago

Please try it!

dotsdl commented 8 years ago

Okay, we have docs that build the environment, including gromacs 5.1, using conda: https://readthedocs.org/projects/mdsynthesis/builds/3881150/

But, when building the class docs for the building blocks, we get errors because the config we ship with is for gromacs 4.x, and so things like grompp can't be found. Quick and dirty solution is to replace current gromacswrapper.cfg with one that works with 5.x names. Longer-term solution is #49.

We cannot install a gromacs 4.x version on readthedocs with conda because there are are no 4.x packages available on the anaconda cloud. If we want this, we'd have to build our own first.

orbeckst commented 8 years ago

We cannot install a gromacs 4.x version on readthedocs with conda because there are are no 4.x packages available on the anaconda cloud. If we want this, we’d have to build our own first.

There are Ubuntu packages that we can use for 4.x … probably in parallel to condo packages.

Oliver Beckstein * orbeckst@gmx.net skype: orbeckst * orbeckst@gmail.com

dotsdl commented 8 years ago

@orbeckst how would we do this under readthedocs? We can't use apt to build the environment on readthedocs.

orbeckst commented 8 years ago

On 13 Apr, 2016, at 16:06, David Dotson notifications@github.com wrote:

@orbeckst how would we do this under readthedocs? We can’t use apt to build the environment on readthedocs.

You’re right, of course. I was thinking about Travis…

If we can have 5.x on RTD then perhaps we should just ship with 5.x cfg.

Oliver Beckstein * orbeckst@gmx.net skype: orbeckst * orbeckst@gmail.com

dotsdl commented 8 years ago

I'll change the existing config to work for gromacs 5.x on the development branch, then. If #49 gets done soonish, then we can support gromacs 4.x out of the box, too.

orbeckst commented 8 years ago

On 13 Apr, 2016, at 22:34, David Dotson wrote:

I'll change the existing config to work for gromacs 5.x on the development branch, then. If #49 gets done soonish, then we can support gromacs 4.x out of the box, too.

Sounds good.

dotsdl commented 8 years ago

So, things are looking better (gromacs tools like like they're being found), but we're still getting some failures. Have a look at the output of the sphinx invocation. I'm not sure what's going on here with just a quick glance: https://readthedocs.org/projects/gromacswrapper/builds/3927393/

orbeckst commented 8 years ago

Not really sure, I find sphinx output difficult to digest. I need to look at it locally.

Just as a note on what needs fixing:

gromacs – GromacsWrapper Package Overview has dead links to

even though gromacs.formats exists. I can't find gromacs.setup anywhere.

orbeckst commented 8 years ago

The docs build locally with sphinx. I will close this issue if they build on RTD.

orbeckst commented 8 years ago

Everything builds on RTD. Minor doc things will be corrected in 0.5.1.