Wait flag - Githubissues

Becksteinlab / imdclient

Streaming analysis from running MD simulations.

https://imdclient.readthedocs.io/

Other

5 stars 0 forks source link

Wait flag #33

Open amruthesht opened 1 month ago

amruthesht commented 1 month ago

Changes made in this Pull Request:

Wait flag added that can be sent anytime by calling _wait(wait_value)
Order of packet definitions changed to maintain consistency

ljwoods2 commented 1 month ago

This is looking fantastic, ping me when you're ready for review

amruthesht commented 1 month ago

@ljwoods2 Ready for review!

ljwoods2 commented 1 month ago

Looks like CI didn't run all tests for this, can you merge develop into your branch? Hopefully that will fix it. There will be some minor documentation merge conflicts because init methods don't seem to get documented with sphinx so Oliver and I moved some stuff around

Here's what I mean, the new docs you wrote aren't visible in what's generated

https://imdclient--33.org.readthedocs.build/en/33/api.html#imdclient