Becksteinlab / kda

Python package used for the analysis of biochemical kinetic diagrams.
GNU General Public License v3.0
5 stars 1 forks source link

Misc updates to verification scripts #24

Closed nawtrey closed 3 years ago

nawtrey commented 3 years ago

Description

Provide a brief description of the PR's purpose here.

Todos

Notable points that this PR has either accomplished or will accomplish.

Questions

Status

codecov[bot] commented 3 years ago

Codecov Report

Merging #24 (d124153) into master (90d9407) will increase coverage by 0.01%. The diff coverage is 100.00%.

nawtrey commented 3 years ago

Lots of changes here. Not an ideal PR by any means, but I have to get these in master before I can move forward.

The only changes to the KDA package code are small. The shift to math.fsum() in calculations.py is tested pretty thoroughly in test_kda.py, and should be inconsequential compared to using the np.sum() function. The only other changes are to svd.py, and those are just moving comments.

The verification scripts aren't tested so they will have no affect on the test suite. These scripts are still in a fluid state, so I likely won't be adding them to the testing suite for some time.

nawtrey commented 3 years ago

Note to self: don't make a README until the scripts are in a stable state

nawtrey commented 3 years ago

All tests are passing and we have a groundbreaking code coverage increase of 0.1%. Merging.