Becksteinlab / kda

Python package used for the analysis of biochemical kinetic diagrams.
GNU General Public License v3.0
3 stars 1 forks source link

TST: Refactors `test_kda.py` #26

Closed nawtrey closed 3 years ago

nawtrey commented 3 years ago
codecov[bot] commented 3 years ago

Codecov Report

Merging #26 (ddd56e8) into master (cc5cb2b) will increase coverage by 5.16%. The diff coverage is 100.00%.

nawtrey commented 3 years ago

Pretty much a complete refactor of the primary testing module, test_kda.py. I want to merge the performance PR #25 but I didn't trust the tests enough to do it. I would still like to address some more of the test recommendations in #3, but this is a really good start for now.

The addition of hypothesis makes the state probability tests much more rigorous, and adding in assertions related to the partial/directional partial diagrams for the 5 test models is also a huge improvement. This should guard against regressions well enough for now, but I would certainly like to see more.

I was also able to find some errors in the code (which are fixed here) because they weren't being tested, which is bad, but the errors were not having any adverse affects on the primary functions so they weren't too bad.

nawtrey commented 3 years ago

All tests are passing, merging now.