At the moment the primary use case for generating the directional partial diagrams in NetworkX diagram for (instead of an array of edges) is to plot them using kda.plotting.draw_diagrams(), but kda.plotting.draw_diagrams() only draws many diagrams when a list of diagrams is input. This is an issue when running the following code:
This is confusing because you expect to be able to feed the diagrams directly into the plotting function. There are basically 2 solutions for this:
change kda.diagrams.generate_directional_partial_diagrams(return_edges=False) to return a list of diagrams instead of an array. This should be done in a consistent way in comparison to kda.diagrams.generate_partial_diagrams() so they can both be used effectively.
change the way that kda.plotting.draw_diagrams() detects multiple diagrams (let it check for an array, for example).
At the moment the primary use case for generating the directional partial diagrams in NetworkX diagram for (instead of an array of edges) is to plot them using
kda.plotting.draw_diagrams()
, butkda.plotting.draw_diagrams()
only draws many diagrams when a list of diagrams is input. This is an issue when running the following code:because it raises the following error:
This is confusing because you expect to be able to feed the diagrams directly into the plotting function. There are basically 2 solutions for this:
kda.diagrams.generate_directional_partial_diagrams(return_edges=False)
to return a list of diagrams instead of an array. This should be done in a consistent way in comparison tokda.diagrams.generate_partial_diagrams()
so they can both be used effectively.kda.plotting.draw_diagrams()
detects multiple diagrams (let it check for an array, for example).