BUG, TST: Fix flux diagram `cbt=True` panel, add test for "color by target" attribute

Becksteinlab / kda

Python package used for the analysis of biochemical kinetic diagrams.

GNU General Public License v3.0

3 stars 1 forks source link

BUG, TST: Fix flux diagram `cbt=True` panel, add test for "color by target" attribute #66

Closed nawtrey closed 2 years ago

nawtrey commented 2 years ago

Description

Change plotting._plot_panel() to retrieve the node list and colors for each individual plot so the flux diagrams are properly colored when cbt=True
Add test test_color_by_target to check the flux diagrams are appropriately assigning target nodes. Also check if _get_node_colors() is returning the correct colors for each flux diagram.
Change _get_node_labels() to return integers for all cases, and simplify.

nawtrey commented 2 years ago

This probably slows down some of the panel plotting since every diagram has to retrieve its own nodes and colors now. But correctness trumps performance, so this is fine. Merging.